[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: helen-frank
Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

I believe there are still some issues with restarting clusters (#1689, #2383, #2824, #2917, #3244). We would need to make sure those are addressed before adding an official command to support that operation, otherwise there will be an expectation that restarting is a supported functionality that will work.

It really is best to just delete and recreate your cluster, since kind clusters are meant to be disposable.

hi, new features should ideally be discussed in an issue first before a PR is sent.

with respect to "starting a cluster" it would also apply to cluster creation where it's automatic. if that's true would it make sense to also have a flag for "kind create cluster", that does not start the containers, letting the user to do it async?

ok, I'll take care of it from now on

I agree with you about adding a flag to 'kind create cluster'.

I believe there are still some issues with restarting clusters (#1689, #2383, #2824, #2917, #3244). We would need to make sure those are addressed before adding an official command to support that operation, otherwise there will be an expectation that restarting is a supported functionality that will work.

It really is best to just delete and recreate your cluster, since kind clusters are meant to be disposable.

Thank you for summarizing your questions

My idea is to provide a simple way to start the cluster first, similar to batch boot nodes, to reduce the difficulty of manual operation. For more network or physical machine related issues, I don't agree that they should be solved in start, start should solve the problem of quickly starting the cluster nodes.

Regarding your point about clusters being disposable, I've probably seen that it's more common to reuse clusters except when running bulk tests. This is because you're deploying applications in the cluster to provide services for development, and you don't want to redeploy them.

/retest

@helen-frank: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Per our contributing guide (linked in CONTRIBUTING.md, the welcome message, our readme, and our docs site), features like this should be discussed in an issue first and the approach agreed upon.

You can workaround this for now with something like kind get nodes | xargs docker start if this implementation is sufficient for your useage.

As-is, support for restarts is limited to a single podman cluster or docker clusters, not guaranteed, and disposable usage is highly encouraged / optimized for.

/close

@helen-frank: Closed this PR.